fix: BROS-14: Optimize yarn test:e2e #7530

niklub · 2025-05-14T14:42:16Z

Summary of the Pull Request

This Pull Request introduces the following changes across multiple components related to testing and error handling:
Test Workflow Update: Modified GitHub Actions workflow to run end-to-end tests using a more specific command (yarn lsf:e2e:ci).

Workflow Update:

Modified .github/workflows/tests-yarn-e2e.yml to use CI specified running command.

AudioUltra fixes

Error rendering logic moved to the parent component to be able to be relevant thanks to the observer.

Testing Improvements:

Remove unnecessary waitForAction
Replaced I.wait with I.waitTicks for more readability and understandability
Added execution waiting to tests where it's needed
Reuse helpers more often
Temporary skip outdated tests
Introduced timeout mechanisms for asynchronous audio loading.
Move some tests to Cypress to avoid running them in parallel which makes them flaky

Helper and Utility Enhancements:

Added seeFocusedElement and hasError methods to improve usability for test writing.
Updated Playwright and other test helpers with additional configuration.
Fix waitForAudio conditions

netlify · 2025-05-14T14:42:21Z

✅ Deploy Preview for heartex-docs ready!

Name	Link
🔨 Latest commit	`f44ed36`
🔍 Latest deploy log	https://app.netlify.com/projects/heartex-docs/deploys/6835b4ecbb2968000835b282
😎 Deploy Preview	https://deploy-preview-7530--heartex-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-05-14T14:42:21Z

✅ Deploy Preview for label-studio-storybook ready!

Name	Link
🔨 Latest commit	`f44ed36`
🔍 Latest deploy log	https://app.netlify.com/projects/label-studio-storybook/deploys/6835b4ecab793e00081fb0e5
😎 Deploy Preview	https://deploy-preview-7530--label-studio-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-05-14T14:42:43Z

✅ Deploy Preview for label-studio-docs-new-theme ready!

Name	Link
🔨 Latest commit	`f44ed36`
🔍 Latest deploy log	https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6835b4ec30bbb300083ccee9
😎 Deploy Preview	https://deploy-preview-7530--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

niklub · 2025-05-14T15:11:18Z

/git merge

Workflow run
Successfully merged: create mode 100644 .github/workflows/apply-linters.yml

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15024410666

netlify · 2025-05-22T05:49:09Z

✅ Deploy Preview for label-studio-playground ready!

Name	Link
🔨 Latest commit	`f44ed36`
🔍 Latest deploy log	https://app.netlify.com/projects/label-studio-playground/deploys/6835b4eccf5c6000086dd786
😎 Deploy Preview	https://deploy-preview-7530--label-studio-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Temporarily skipped two audio error handling tests to prevent false negatives.

Gondragos · 2025-05-22T08:32:13Z

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/lib/Tooltip/tooltip.stories.tsx

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15181918674

This reverts commit 65b2a48.

Gondragos · 2025-05-26T12:35:36Z

/git merge

Workflow run
Successfully merged: create mode 100644 web/apps/playground/src/hooks/useCopyText.ts

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15254104277

hlomzik · 2025-05-27T11:39:37Z

web/libs/editor/tests/e2e/steps_file.js

@@ -22,4 +22,8 @@ module.exports = () =>
      await action();
      this._performActionEnd(name);
    },
+
+    waitTicks(n) {


Love this approach and name!

hlomzik · 2025-05-27T11:41:52Z

web/libs/editor/tests/e2e/tests/image.zoom-rotate.test.js

What are we waiting for here? Could it also be waitTicks()?

In this case ticks were not a stable solution. Somehow it needs more time to wait.

hlomzik

Add todo comments to all skipped tests, so we'll know what to do with them later. The rest is great, just couple of small questions!

Annotated and skipped three e2e tests due to outdated or problematic functionality: - Taxonomy read-only in annotation history. - Sync issues with multiple audio playback. - Removing textarea items in 'region-list' mode. Each test now includes a TODO comment to clarify necessary actions for future fixes.

Gondragos · 2025-05-27T12:47:31Z

/git merge

Workflow run
Successfully merged: create mode 100644 docs/themes/v2/source/images/import-export/keypoints.png

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15275674435

fix: BROS-14: Optimize yarn test:e2e

03219e5

niklub requested review from hlomzik, Gondragos and nick-skriabin as code owners May 14, 2025 14:42

github-actions bot added the fix label May 14, 2025

niklub and others added 2 commits May 14, 2025 15:13

Merge branch 'develop' into 'fb-bros-14'

acddf3d

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15024410666

Add parallel execution in CI

c173863

niklub requested a review from a team as a code owner May 15, 2025 14:18

nik and others added 7 commits May 15, 2025 15:19

Cleanup

734b4cd

try: Await for LS destroy

39270b9

try fixing smoke tests

a8fb2a0

Merge branch 'develop' into fb-bros-14

e5f4f47

fix: fix e2e tests

8a06936

test: skip fully broken e2e test scenarios

e9aa1cf

linting fixes

546663e

Gondragos requested a review from a team as a code owner May 22, 2025 05:48

Gondragos added 5 commits May 22, 2025 07:14

fix: configure waitForAction in audio errors test

d6294c4

test: skip flacky failing audio error scenarios

336b519

Temporarily skipped two audio error handling tests to prevent false negatives.

fix: update lsf:e2e:parallel script command

2effa8f

Upgrade Playwright dependency to v1.52.0

65b2a48

fix: update e2e workflow to use correct command

0a54690

Gondragos and others added 3 commits May 22, 2025 08:40

Merge branch 'develop' into 'fb-bros-14'

1a4fb8b

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15181918674

Revert "Upgrade Playwright dependency to v1.52.0"

c48809a

This reverts commit 65b2a48.

Merge commit '1a4fb8bab02b5884bcc101bbcfa63923ba9bf875' into fb-bros-14

790d444

Gondragos requested a review from hlomzik May 23, 2025 17:00

Gondragos added 3 commits May 23, 2025 18:19

test: revert wait time for magic wand test

e72a77f

fix: adjust wait timings

6c37150

test: add behavior based wait

6fab90f

Gondragos force-pushed the fb-bros-14 branch from 0c62a09 to 6fab90f Compare May 23, 2025 21:23

Gondragos added 2 commits May 23, 2025 22:42

fix: add custom timeout to allow to process loading audio

96b2854

fix: correct region count validation in test

61671bd

Gondragos force-pushed the fb-bros-14 branch from 4b39409 to 61671bd Compare May 23, 2025 22:03

Gondragos added 3 commits May 26, 2025 11:29

fix: AudioUltra errors rendering

f36d37b

fix: fix modal handling in e2e tests

9cf40a3

test: Fix DateTime validation test with Modals helper

0fc35f7

Gondragos force-pushed the fb-bros-14 branch from 90d8d64 to 0fc35f7 Compare May 26, 2025 11:18

fix: add wait to stabilize text selection

0523d1f

Gondragos and others added 5 commits May 26, 2025 12:37

Merge branch 'develop' into 'fb-bros-14'

10f8d6c

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15254104277

test: configure waitForAction in shortcuts test

001ab74

Merge remote-tracking branch 'origin/fb-bros-14' into fb-bros-14

044829b

fix: ensure stability by adding waitTicks in audio tests

4558a51

fix: ensure modal stability with additional wait

1b0ac9b

hlomzik reviewed May 27, 2025

View reviewed changes

hlomzik requested changes May 27, 2025

View reviewed changes

Gondragos requested a review from hlomzik May 27, 2025 12:29

hlomzik approved these changes May 27, 2025

View reviewed changes

Gondragos enabled auto-merge (squash) May 27, 2025 12:46

Merge branch 'develop' into 'fb-bros-14'

f44ed36

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15275674435

Gondragos merged commit 1ae7f3c into develop May 27, 2025
43 checks passed

robot-ci-heartex deleted the fb-bros-14 branch May 27, 2025 13:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: BROS-14: Optimize yarn test:e2e #7530

fix: BROS-14: Optimize yarn test:e2e #7530

Uh oh!

niklub commented May 14, 2025 •

edited by Gondragos

Loading

Uh oh!

netlify bot commented May 14, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 14, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 14, 2025 •

edited

Loading

Uh oh!

niklub commented May 14, 2025 •

edited by robot-ci-heartex

Loading

Uh oh!

netlify bot commented May 22, 2025 •

edited

Loading

Uh oh!

Gondragos commented May 22, 2025 •

edited by robot-ci-heartex

Loading

Uh oh!

Gondragos commented May 26, 2025 •

edited by robot-ci-heartex

Loading

Uh oh!

hlomzik May 27, 2025

Uh oh!

hlomzik May 27, 2025

Uh oh!

Gondragos May 27, 2025

Uh oh!

hlomzik left a comment

Uh oh!

Gondragos commented May 27, 2025 •

edited by robot-ci-heartex

Loading

Uh oh!

Uh oh!

Uh oh!

fix: BROS-14: Optimize yarn test:e2e #7530

fix: BROS-14: Optimize yarn test:e2e #7530

Uh oh!

Conversation

niklub commented May 14, 2025 • edited by Gondragos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

Workflow Update:

AudioUltra fixes

Testing Improvements:

Helper and Utility Enhancements:

Uh oh!

netlify bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for heartex-docs ready!

Uh oh!

netlify bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for label-studio-storybook ready!

Uh oh!

netlify bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for label-studio-docs-new-theme ready!

Uh oh!

niklub commented May 14, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for label-studio-playground ready!

Uh oh!

Gondragos commented May 22, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gondragos commented May 26, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hlomzik May 27, 2025

Choose a reason for hiding this comment

Uh oh!

hlomzik May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Gondragos May 27, 2025

Choose a reason for hiding this comment

Uh oh!

hlomzik left a comment

Choose a reason for hiding this comment

Uh oh!

Gondragos commented May 27, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niklub commented May 14, 2025 •

edited by Gondragos

Loading

netlify bot commented May 14, 2025 •

edited

Loading

netlify bot commented May 14, 2025 •

edited

Loading

netlify bot commented May 14, 2025 •

edited

Loading

niklub commented May 14, 2025 •

edited by robot-ci-heartex

Loading

netlify bot commented May 22, 2025 •

edited

Loading

Gondragos commented May 22, 2025 •

edited by robot-ci-heartex

Loading

Gondragos commented May 26, 2025 •

edited by robot-ci-heartex

Loading

Gondragos commented May 27, 2025 •

edited by robot-ci-heartex

Loading